xiazcy commented on code in PR #2366:
URL: https://github.com/apache/tinkerpop/pull/2366#discussion_r1411086068
##########
gremlin-go/driver/anonymousTraversal.go:
##########
@@ -22,7 +22,7 @@ package gremlingo
// AnonymousTraversalSource interface for generating anonymous traversals.
type AnonymousTraversalSource interface {
// WithRemote used to set the DriverRemoteConnection within the
AnonymousTraversalSource
- WithRemote(drc *DriverRemoteConnection) *GraphTraversalSource
+ With(drc *DriverRemoteConnection) *GraphTraversalSource
Review Comment:
Are we just deprecating the usage? If so, we should keep WithRemote() in
addition to adding With(), as removing it will remove the method implementation
from the interface. I.e.:
```suggestion
With(drc *DriverRemoteConnection) *GraphTraversalSource
// WithRemote used to set the DriverRemoteConnection within the
AnonymousTraversalSource
//
// Deprecated: WithRemote replaced by With
WithRemote(remote *DriverRemoteConnection) *GraphTraversalSource
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
