Cole-Greer commented on code in PR #2364:
URL: https://github.com/apache/tinkerpop/pull/2364#discussion_r1412670221
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/unit/traversal-test.js:
##########
@@ -274,6 +274,27 @@ describe('Traversal', function () {
});
});
+ describe('not opened transactions', function() {
+ it('should not allow commit for not opened transactions', async function()
{
+ const g = anon.traversal().withRemote(new MockRemoteConnection());
+ const tx = g.tx();
+ try {
+ await tx.commit();
+ } catch (err) {
+ assert.strictEqual('Cannot commit a transaction that is not started',
err.message);
Review Comment:
This test may still pass if `tx.commit()` does not throw any exception.
Similar comment for other JS and python tests. Otherwise changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
