EricSites commented on code in PR #2424:
URL: https://github.com/apache/tinkerpop/pull/2424#discussion_r1441072113


##########
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs:
##########
@@ -82,21 +82,22 @@ public bool MoveNext()
         }
         
         private bool MoveNextInternal()
-        {                   
+        {
             if (_fetchedNext) return _nextAvailable;
+
+            if (!_nextAvailable || _nextAvailable && 
TraverserEnumerator.Current?.Bulk == 0)

Review Comment:
   This code will also throw an exception if called without first starting the 
iterator: You will need to track that the iterator has not been started.
   
   ```.csharp
   private object GetCurrent()
   {
       // Use dynamic to object to prevent runtime dynamic conversion evaluation
       return TraverserEnumerator.Current?.Object;
   }
   ```
   
   Please review the new [.Net code 
here](https://source.dot.net/#PresentationFramework/MS/Internal/WindowsRuntime/Generated/WinRT/Projections/IEnumerable.cs,239)
 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to