kenhuuu commented on code in PR #2506:
URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1511974766
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js:
##########
@@ -112,8 +95,36 @@ exports.getUserAgentHeader = function getUserAgentHeader() {
return 'User-Agent';
};
-const userAgent = generateUserAgent();
+exports.getUserAgent = async () => {
Review Comment:
Please excuse my lack of knowledge in JavaScript, but it seems like this
changes the user agent header that we will be sending to the server. If this is
the case, we will want to change this to be more like how the NodeUserAgent
works. Our specification for the user agent can be found at
https://tinkerpop.apache.org/docs/current/dev/provider/#_graph_driver_provider_requirements
. Notably the form should be of "[Application Name] [GLV Name].[Version]
[Language Runtime Version] [OS].[Version] [CPU Architecture]". The reason this
is important is because the server will likely start using this value in the
future to enable/disable features based on the GLV's version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
