vkagamlyk commented on code in PR #2515:
URL: https://github.com/apache/tinkerpop/pull/2515#discussion_r1522028418
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/sasl-authentication-tests.js:
##########
@@ -69,38 +68,43 @@ describe('DriverRemoteConnection', function () {
it('should return error when using ws:// for a TLS configured server',
function () {
const authenticator = new PlainTextSaslAuthenticator('stephen',
'password');
- connection = helper.getDriverRemoteConnection(badServerAuthUrl, {
+ connection = getDriverRemoteConnection(badServerAuthUrl, {
authenticator: authenticator,
- rejectUnauthorized: false
+ rejectUnauthorized: false,
});
- return connection.submit(new Bytecode().addStep('V',
[]).addStep('tail', []))
- .then(function() {
- assert.fail("server is running TLS and trying to connect with
ws:// so this should result in error thrown");
- })
- .catch(function (err) {
- if (err instanceof AssertionError) throw err;
- assert.ok(err);
- assert.ok(err.message === 'socket hang up');
- });
+ return connection
+ .submit(new Bytecode().addStep('V', []).addStep('tail', []))
+ .then(function () {
+ assert.fail('server is running TLS and trying to connect with
ws:// so this should result in error thrown');
+ })
+ .catch(function (err) {
+ if (err instanceof AssertionError) throw err;
+ assert.ok(err);
+ assert.ok(err.message === 'socket hang up');
+ });
});
it('should return error when using ws:// for a TLS configured server',
function () {
const authenticator = new PlainTextSaslAuthenticator('stephen',
'password');
- connection = helper.getDriverRemoteConnection(badServerAuthUrl, {
+ connection = getDriverRemoteConnection(badServerAuthUrl, {
authenticator: authenticator,
- rejectUnauthorized: false
+ rejectUnauthorized: false,
});
- const g = traversal().with_(connection);
- return g.V().toList().then(function() {
- assert.fail("server is running TLS and trying to connect with ws://
so this should result in error thrown");
- }).catch(function(err) {
- if (err instanceof AssertionError) throw err;
- assert.ok(err);
- assert.ok(err.message === 'socket hang up');
+ const g = traversal().withRemote(connection);
Review Comment:
`withRemote` will be depricated in 4.0, `with_(` should be used.
the same thing a few more times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
