spmallette commented on code in PR #2600:
URL: https://github.com/apache/tinkerpop/pull/2600#discussion_r1601811702
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##########
@@ -665,13 +665,22 @@ private void appendConnections(final StringBuilder sb,
final Connection connecti
final List<Connection> connections) {
final int connectionCount = connections.size();
for (int ix = 0; ix < connectionCount; ix++) {
+ try {
final Connection c = connections.get(ix);
- if (c.equals(connectionToCallout))
+ if (c.equals(connectionToCallout)) {
sb.append("==> ");
- else
+ }
+ else {
sb.append("> ");
-
+ }
sb.append(c.getConnectionInfo(false));
+ } catch (final ArrayIndexOutOfBoundsException ex) {
Review Comment:
i mentioned this to @upadhyay-prashant elsewhere but others looking at this,
i think we want to try to handle this differently as missing logs in the event
of failure might prove to be confusing when debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
