ministat commented on code in PR #2634: URL: https://github.com/apache/tinkerpop/pull/2634#discussion_r1626069017
########## spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java: ########## @@ -51,6 +51,15 @@ * @author Marko A. Rodriguez (http://markorodriguez.com) */ public class SparkTest extends AbstractSparkTest { + @Test + public void testCustomizedSparkAppName() { + final String appName = "SparkAppNameTest"; + final org.apache.spark.SparkConf sparkConfiguration = new org.apache.spark.SparkConf(); Review Comment: No special purpose. My impression is many "import" sometimes brings trouble and confusion to the current file namespace, like the org.apache.commons.configuration2.Configuration and org.apache.commons.configuration.Configuration. So, I tried to avoid that. In addition, org.apache.spark.SparkConf is not too long and not impact the reading. ########## spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/structure/SparkTest.java: ########## @@ -51,6 +51,15 @@ * @author Marko A. Rodriguez (http://markorodriguez.com) */ public class SparkTest extends AbstractSparkTest { + @Test + public void testCustomizedSparkAppName() { Review Comment: Good idea. I'll add one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
