vkagamlyk commented on code in PR #2640:
URL: https://github.com/apache/tinkerpop/pull/2640#discussion_r1628455738
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/grammar/TraversalMethodVisitor.java:
##########
Review Comment:
`visitTraversalMethod_option_Merge_Map_Cardinality` have middle argument
(Map) defined in grammar as `genericLiteralMapNullableArgument`, but we handle
only `genericLiteralMap` and `nullLiteral` cases, not `variable`.
```
@Override
public Traversal visitTraversalMethod_option_Merge_Map_Cardinality(final
GremlinParser.TraversalMethod_option_Merge_Map_CardinalityContext ctx) {
if (ctx.genericLiteralMapNullableArgument().nullLiteral() != null) {
return
this.graphTraversal.option(antlr.argumentVisitor.parseMerge(ctx.traversalMergeArgument()),
(Map) null);
}
// proposed addition
if (ctx.genericLiteralMapNullableArgument().variable() != null) {
return
graphTraversal.option(antlr.argumentVisitor.parseMerge(ctx.traversalMergeArgument()),
(Map)
antlr.argumentVisitor.visitVariable(ctx.genericLiteralMapNullableArgument().variable()),
TraversalEnumParser.parseTraversalEnumFromContext(Cardinality.class,
ctx.traversalCardinality()));
}
// end of proposed addition
return
graphTraversal.option(antlr.argumentVisitor.parseMerge(ctx.traversalMergeArgument()),
(Map) new
GenericLiteralVisitor(antlr).visitGenericLiteralMap(ctx.genericLiteralMapNullableArgument().genericLiteralMap()),
TraversalEnumParser.parseTraversalEnumFromContext(Cardinality.class,
ctx.traversalCardinality()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
