Cole-Greer commented on PR #2640: URL: https://github.com/apache/tinkerpop/pull/2640#issuecomment-2153654347
Thanks for all of the work on this, it is a big step forward to have modern gremlin-lang based translators. I primarily focused my review on the Go and JS translators here as it is a big PR and hard to capture everything at once. Prior to the release of TP4, I would like to add some tests to ensure successful translation of some of the more obscure literals, however I think that can be out of scope for this PR as the new translators are at least as well tested as the old ones. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
