(tinkerpop) branch 3.7-dev updated: Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step (#2687)

[xiazcy]

This is an automated email from the ASF dual-hosted git repository.

xiazcy pushed a commit to branch 3.7-dev
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


The following commit(s) were added to refs/heads/3.7-dev by this push:
     new 812bc1de78 Add getter for private fields to Concat, Conjoin, 
SplitGlobal/Local Step (#2687)
812bc1de78 is described below

commit 812bc1de7888cc9f8ade71121d0bb605299fb8b6
Author: Norio Akagi <norak...@amazon.com>
AuthorDate: Wed Jul 17 10:06:30 2024 -0700

    Add getter for private fields to Concat, Conjoin, SplitGlobal/Local Step 
(#2687)
---
 CHANGELOG.asciidoc                                                | 1 +
 .../tinkerpop/gremlin/process/traversal/step/map/ConcatStep.java  | 8 ++++++++
 .../tinkerpop/gremlin/process/traversal/step/map/ConjoinStep.java | 4 ++++
 .../gremlin/process/traversal/step/map/SplitGlobalStep.java       | 4 ++++
 .../gremlin/process/traversal/step/map/SplitLocalStep.java        | 4 ++++
 5 files changed, 21 insertions(+)

diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 629d5f6109..56712a17c4 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -34,6 +34,7 @@ This release also includes changes from <<release-3-6-8, 
3.6.8>>.
 * Fixed so that `TrimGlobalStep` and `TrimLocalStep` have the same character 
control handling as `Ltrim` and `Rtrim`
 * Fix a bug in `MaxLocalStep`, `MinLocalStep`, `MeanLocalStep` and 
`SumLocalStep` that it throws `NoSuchElementException` when encounters an empty 
iterator as input.
 * Fix cases where Map keys of incomparable types could panic in `gremlin-go`.
+* Added getter method to `ConcatStep`, `ConjoinStep`, `SplitGlobalStep` and 
`SplitLocalStep` for their private fields.
 
 [[release-3-7-2]]
 === TinkerPop 3.7.2 (April 8, 2024)
diff --git 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConcatStep.java
 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConcatStep.java
index 04811d823b..86d737f022 100644
--- 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConcatStep.java
+++ 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConcatStep.java
@@ -120,6 +120,14 @@ public final class ConcatStep<S> extends ScalarMapStep<S, 
String> implements Tra
         return this.isNullString? null : sb.toString();
     }
 
+    public List<String> getConcatStrings() {
+        return this.concatStrings;
+    }
+
+    public String getStringArgsResult() {
+        return this.stringArgsResult;
+    }
+
     @Override
     public Set<TraverserRequirement> getRequirements() {
         return this.getSelfAndChildRequirements(TraverserRequirement.OBJECT);
diff --git 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConjoinStep.java
 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConjoinStep.java
index 0f38739f9b..ce6818b473 100644
--- 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConjoinStep.java
+++ 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ConjoinStep.java
@@ -66,6 +66,10 @@ public final class ConjoinStep<S> extends ScalarMapStep<S, 
String> implements Li
         }
     }
 
+    public String getDelimiter() {
+        return this.delimiter;
+    }
+
     @Override
     public Set<TraverserRequirement> getRequirements() { return 
Collections.singleton(TraverserRequirement.OBJECT); }
 
diff --git 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitGlobalStep.java
 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitGlobalStep.java
index 2465e72101..14e886edfe 100644
--- 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitGlobalStep.java
+++ 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitGlobalStep.java
@@ -60,6 +60,10 @@ public final class SplitGlobalStep<S, E> extends 
ScalarMapStep<S, E> implements
         return null == item? null : (E) 
Arrays.asList(StringUtils.splitByWholeSeparator((String) item, this.separator));
     }
 
+    public String getSeparator() {
+        return this.separator;
+    }
+
     @Override
     public Set<TraverserRequirement> getRequirements() {
         return Collections.singleton(TraverserRequirement.OBJECT);
diff --git 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitLocalStep.java
 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitLocalStep.java
index 61a9901a84..5d638c74ca 100644
--- 
a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitLocalStep.java
+++ 
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SplitLocalStep.java
@@ -56,6 +56,10 @@ public final class SplitLocalStep<S, E> extends 
StringLocalStep<S, E> implements
     @Override
     public String getStepName() { return "split(local)"; }
 
+    public String getSeparator() {
+        return this.separator;
+    }
+
     @Override
     public int hashCode() {
         int result = super.hashCode();