kenhuuu commented on code in PR #2753:
URL: https://github.com/apache/tinkerpop/pull/2753#discussion_r1744126212
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java:
##########
@@ -149,6 +155,18 @@ protected void initChannel(final SocketChannel
socketChannel) {
configure(pipeline);
pipeline.addLast(PIPELINE_GREMLIN_HANDLER, new
GremlinResponseHandler(pending));
}
+
+ @Override
+ public void connected() {
+ if (supportsSsl()) {
+ try {
+ // Block until the handshake is complete either
successfully or with an error.
+ sslHandler.handshakeFuture().sync();
+ } catch (Exception ex) {
+ throw new ConnectionException(connection.getUri(),
HANDSHAKE_ERROR, ex);
Review Comment:
This might leak the channel. Can you confirm if something actually closes
the channel if an exception is thrown here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
