kenhuuu commented on code in PR #2790:
URL: https://github.com/apache/tinkerpop/pull/2790#discussion_r1778863848


##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONMapperTest.java:
##########
@@ -150,8 +162,10 @@ public void shouldHandlePath() throws Exception {
                 extend("alice", new HashSet<>(Collections.singletonList("c")));
         final String json = mapper.writeValueAsString(p);
 
-        if (version.startsWith("v1") || version.startsWith("v3") || 
version.startsWith("v4"))
+        if (version.startsWith("v1") || version.startsWith("v3"))

Review Comment:
   Probably. The old GraphSONMappers should stay as they can be used with io(). 
It would be best if users updated their storage format to v4, but all versions 
should be provided so that the user can read in an older version then write 
into v4.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to