Cole-Greer commented on code in PR #3090:
URL: https://github.com/apache/tinkerpop/pull/3090#discussion_r2029388374
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/DatetimeHelper.java:
##########
@@ -93,45 +97,41 @@ public static String format(final Instant d) {
* </ul>>
*
*/
- public static Date parse(final String d) {
+ public static OffsetDateTime parse(final String d) {
Review Comment:
There's a lot going on in this method. Based on the javadoc comment, could
it simply be replaced with
[OffsetDateTime.parse(String)](https://docs.oracle.com/javase/8/docs/api/java/time/OffsetDateTime.html#parse-java.lang.CharSequence-)
or
[OffsetDateTime.from(TemporalAccessor)](https://docs.oracle.com/javase/8/docs/api/java/time/OffsetDateTime.html#from-java.time.temporal.TemporalAccessor-)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
