andreachild commented on code in PR #3090:
URL: https://github.com/apache/tinkerpop/pull/3090#discussion_r2037885622
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/DateDiffStep.java:
##########
@@ -36,34 +39,61 @@
*/
public final class DateDiffStep<S> extends ScalarMapStep<S, Long> implements
TraversalParent {
- private Date value;
- private Traversal.Admin<S, Date> dateTraversal;
+ private OffsetDateTime value;
+ private Traversal.Admin<S, OffsetDateTime> dateTraversal;
public DateDiffStep(final Traversal.Admin traversal, final Date value) {
+ super(traversal);
+ this.value = value == null ? null :
value.toInstant().atOffset(ZoneOffset.UTC);
+ }
+
+ public DateDiffStep(final Traversal.Admin traversal, final OffsetDateTime
value) {
super(traversal);
this.value = value;
}
- public DateDiffStep(final Traversal.Admin traversal, final Traversal<?,
Date> dateTraversal) {
+ public DateDiffStep(final Traversal.Admin traversal, final Traversal<?, ?>
dateTraversal) {
super(traversal);
this.dateTraversal = this.integrateChild(dateTraversal.asAdmin());
Review Comment:
If the incoming `Traversal` is of type `?` then shouldn't
`this.dateTraversal` be of type `?` as well since there's no guarantee the
traversal resolves to an `OffsetDateTime`?
The current typing confuses IntelliJ:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
