EchoNullify commented on code in PR #3121:
URL: https://github.com/apache/tinkerpop/pull/3121#discussion_r2107914731


##########
gremlin-dotnet/build/generate.groovy:
##########
@@ -94,7 +94,7 @@ radishGremlinFile.withWriter('UTF-8') { Writer writer ->
 
 
     // some traversals may require a static translation if the translator 
can't handle them for some reason
-    def staticTranslate = [:]
+    def staticTranslate = ["g_withSackX_128bX_injectX1bX_sackXminusX_sack" : " 
              {\"g_withSackX_128bX_injectX1bX_sackXminusX_sack\", new 
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>> 
{(g,p) =>g.WithSack((short) -128).Inject<object>((short) 
1).Sack(Operator.Minus).Sack<object>()}}, "]

Review Comment:
   because for dotnet a byte can be 0 to 255 and is not signed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to