Cole-Greer commented on code in PR #3153: URL: https://github.com/apache/tinkerpop/pull/3153#discussion_r2196294195
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AsNumberStep.java: ########## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.process.traversal.step.map; + +import org.apache.commons.lang3.math.NumberUtils; +import org.apache.tinkerpop.gremlin.process.traversal.N; +import org.apache.tinkerpop.gremlin.process.traversal.Traversal; +import org.apache.tinkerpop.gremlin.process.traversal.Traverser; +import org.apache.tinkerpop.gremlin.process.traversal.traverser.TraverserRequirement; +import org.apache.tinkerpop.gremlin.structure.util.StringFactory; +import org.apache.tinkerpop.gremlin.util.NumberHelper; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.util.Calendar; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; + +/** + * Reference implementation for number parsing step. + */ +public final class AsNumberStep<S> extends ScalarMapStep<S, Number> { + + private N numberToken; + + public AsNumberStep(final Traversal.Admin traversal) { + super(traversal); + this.numberToken = null; + } + + public AsNumberStep(final Traversal.Admin traversal, final N numberToken) { + super(traversal); + this.numberToken = numberToken; + } + + @Override + protected Number map(Traverser.Admin<S> traverser) { + final Object object = traverser.get(); + if (object instanceof String) { + String numberText = (String) object; + Number number = parseNumber(numberText); + return numberToken == null ? autoNumber(number) : castNumber(number, numberToken); + } else if (object instanceof Number) { + Number number = (Number) object; + return numberToken == null ? autoNumber(number) : castNumber(number, numberToken); + } + throw new IllegalArgumentException(String.format("Can't parse type %s as number.", object == null ? "null" : object.getClass().getSimpleName())); + } + + @Override + public Set<TraverserRequirement> getRequirements() { + return Collections.singleton(TraverserRequirement.OBJECT); + } + + @Override + public void setTraversal(final Traversal.Admin<?, ?> parentTraversal) { + super.setTraversal(parentTraversal); + } + + @Override + public int hashCode() { + int result = super.hashCode(); + result = 31 * result + (numberToken != null ? numberToken.hashCode() : 0); + return result; + } + + @Override + public AsNumberStep<S> clone() { + final AsNumberStep<S> clone = (AsNumberStep<S>) super.clone(); + clone.numberToken = this.numberToken; + return clone; + } + + @Override + public String toString() { + return StringFactory.stepString(this); + } + + public static Number parseNumber(final String value) { + try { + boolean isFloatingPoint = value.contains(".") || value.contains("e") || value.contains("E"); Review Comment: That would have a nice benefit of giving us something like hexadecimal parsing for free as well. I am concerned by this line in the [javadocs](commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/math/NumberUtils.html#createNumber(java.lang.String)) though: > If a type specifier is not found, it will check for a decimal point and then try successively larger types from Integer to BigInteger and from Float to BigDecimal. I'm not sure how it decides if a number "fits" into a float, but I would be concerned of any precision implications as numbers approach the range limits of float. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
