vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216962810
##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
if (container != null && container.get() != null)
throw Exceptions.vertexWithIdAlreadyExists(idValue);
+ long version = txNumber;
+ if (container != null && container.isDeleted() &&
container.getModified() != null) {
Review Comment:
`vertexWithIdAlreadyExists` is in `else if` block, so can't be thrown when
`unmarkDeleted` called
It's ok to leave it as you did if it works, it's too minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
