andreachild commented on code in PR #3162: URL: https://github.com/apache/tinkerpop/pull/3162#discussion_r2220264073
########## gremlin-console/src/main/groovy/org/apache/tinkerpop/gremlin/console/RemoteParser.groovy: ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.console + +import org.apache.groovy.groovysh.ParseCode +import org.apache.groovy.groovysh.ParseStatus +import org.apache.groovy.groovysh.Parsing +import org.codehaus.groovy.control.CompilerConfiguration +import org.codehaus.groovy.control.MultipleCompilationErrorsException +import org.codehaus.groovy.control.messages.Message +import org.codehaus.groovy.control.messages.SyntaxErrorMessage + +/** + * A {@link Parsing} implementation that detects if a Groovy script is complete or incomplete. This implementation uses + * the Groovy compiler to try to compile the script and analyzes any compilation errors to determine if the script is + * incomplete. It does not evaluate the script, which prevents local execution and potential local failure. + */ +class RemoteParser implements Parsing { + + // Try to compile the script + def config = new CompilerConfiguration() + + // Create a custom GroovyClassLoader that doesn't write class files + def gcl = new GroovyClassLoader(this.class.classLoader, config) { Review Comment: Nit: just for consistency ```suggestion private final GroovyClassLoader gcl = new GroovyClassLoader(this.class.classLoader, config) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
