This is an automated email from the ASF dual-hosted git repository.

xiazcy pushed a change to branch TINKERPOP-3166_asNumber
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


    from 0ae19cdac0 Apply suggestions from code review
     add 13a51e9dfb handled overflow edge cases in bigint conversion and 
refactored coerceTo and castTo to use the same conversion logic in 
NumberHelper. Removed `n` from N enum value in Grammar, and used `_` suffix for 
keyword collisions in Java/Groovy/JS.

No new revisions were added by this update.

Summary of changes:
 docs/src/reference/the-traversal.asciidoc          |  19 +-
 docs/src/upgrade/release-3.8.x.asciidoc            |  14 +-
 .../language/grammar/GenericLiteralVisitor.java    |   5 +
 .../language/grammar/TraversalEnumParser.java      |  11 +
 .../language/grammar/TraversalMethodVisitor.java   |   2 +-
 .../translator/GroovyTranslateVisitor.java         |   9 +
 .../language/translator/JavaTranslateVisitor.java  |  11 +
 .../translator/JavascriptTranslateVisitor.java     |   9 +
 .../tinkerpop/gremlin/process/traversal/N.java     |  26 +--
 .../io/binary/TypeSerializerRegistry.java          |  49 +----
 .../structure/io/binary/types/EnumSerializer.java  |   1 -
 .../{MonthDaySerializer.java => NSerializer.java}  |  22 +-
 .../structure/io/graphson/GraphSONModule.java      |   8 +-
 .../io/graphson/TraversalSerializersV2.java        |  40 +++-
 .../io/graphson/TraversalSerializersV3.java        |  40 +++-
 .../tinkerpop/gremlin/util/NumberHelper.java       |  88 ++++----
 .../grammar/GeneralLiteralVisitorTest.java         |  38 +++-
 .../language/translator/GremlinTranslatorTest.java |  18 ++
 .../traversal/step/map/AsNumberStepTest.java       | 236 +++++++++++----------
 .../tinkerpop/gremlin/util/NumberHelperTest.java   |  30 +--
 .../src/Gremlin.Net/Process/Traversal/N.cs         |  32 +--
 .../Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs |  24 +--
 gremlin-go/driver/cucumber/gremlin.go              |  24 +--
 gremlin-go/driver/serializer.go                    |   2 +-
 gremlin-go/driver/traversal.go                     |  32 +--
 .../gremlin-javascript/lib/process/traversal.js    |  10 +-
 .../gremlin-javascript/test/cucumber/gremlin.js    |  24 +--
 .../test/unit/graphbinary/AnySerializer-test.js    |   6 +-
 .../test/unit/graphbinary/EnumSerializer-test.js   |   1 +
 gremlin-language/src/main/antlr4/Gremlin.g4        |  16 +-
 .../language/corpus/DocumentationReader.java       |   4 +-
 .../python/gremlin_python/process/traversal.py     |  21 +-
 gremlin-python/src/main/python/radish/gremlin.py   |  24 +--
 .../tests/driver/test_driver_remote_connection.py  |   2 +-
 .../gremlin/test/features/map/AsNumber.feature     |  46 ++--
 35 files changed, 542 insertions(+), 402 deletions(-)
 copy 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/binary/types/{MonthDaySerializer.java
 => NSerializer.java} (67%)

Reply via email to