Cole-Greer commented on code in PR #3186:
URL: https://github.com/apache/tinkerpop/pull/3186#discussion_r2278009462
##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/Where.feature:
##########
@@ -92,11 +92,10 @@ Feature: Step - where()
Scenario:
g_withSideEffectXa_josh_peterX_VX1X_outXcreatedX_inXcreatedX_name_whereXwithinXaXX
Given the modern graph
- And using the parameter xx1 defined as "l[josh,peter]"
And using the parameter vid1 defined as "v[marko].id"
And the traversal of
"""
- g.withSideEffect("a",
xx1).V(vid1).out("created").in("created").values("name").where(P.within("a"))
+ g.withSideEffect("a",
["josh","peter"]).V(vid1).out("created").in("created").values("name").where(P.within("a"))
Review Comment:
There are no strict rules in cases like this one. Either inlining the side
effect or using the new syntax is fine.
Passing a parameter to `withSideEffect()` will be disallowed after the
GValue work is complete. The only time a side effect cannot be inlined is if it
contains a dynamic value such as `v[marko].id` which needs to be processed
through the test framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
