Cole-Greer commented on code in PR #3157:
URL: https://github.com/apache/tinkerpop/pull/3157#discussion_r2283286025
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/P.java:
##########
@@ -90,17 +156,18 @@ public boolean equals(final Object other) {
return other instanceof P &&
((P) other).getClass().equals(this.getClass()) &&
((P) other).getBiPredicate().equals(this.biPredicate) &&
- ((((P) other).getOriginalValue() == null && this.originalValue
== null) || ((P) other).getOriginalValue().equals(this.originalValue));
+ ((((P) other).variables == null && this.variables == null) ||
(((P) other).variables != null && ((P)
other).variables.equals(this.variables))) &&
+ ((((P) other).literals == null && this.literals == null) ||
(((P) other).literals != null && CollectionUtils.isEqualCollection(((P)
other).literals, this.literals)));
}
@Override
public String toString() {
- return null == this.originalValue ? this.biPredicate.toString() :
this.biPredicate.toString() + "(" + this.originalValue + ")";
+ return literals.isEmpty() && variables.isEmpty() ?
this.biPredicate.toString() : this.biPredicate.toString() + "(" + getValue() +
")";
Review Comment:
I opted to revert this back to the old behaviour via:
```
return null == this.getValue() ? this.biPredicate.toString() :
this.biPredicate.toString() + "(" + this.getValue() + ")";
```
I still think `eq(null)` may be more clear, but there is enough change
already contained in this PR that I'd like to avoid unnecessary changes where
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
