andreachild commented on code in PR #3203:
URL: https://github.com/apache/tinkerpop/pull/3203#discussion_r2349834306
##########
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/driver/ClientConnectionIntegrateTest.java:
##########
@@ -227,10 +227,17 @@ public void
overLimitOperationsShouldDelegateToSingleNewConnection() throws Inte
}
});
- assertEquals(2, connectionBorrowCount.size());
- for (int finalBorrowCount : connectionBorrowCount.values()) {
- assertEquals(usagePerConnection, finalBorrowCount);
- }
+ // The intent of this test is to ensure that the driver grows from 1
connection to only as many as needed to satisfy
maxSimultaneousUsagePerConnection limits
+ // (i.e. 2 fully utilized connections at 3 operations each for a total
of 6 operations).
+ // On CI / Github runners, ephemeral third connections can appear.
Review Comment:
> So perhaps we can just leave the test as is, and set
.maxConnectionPoolSize(2)?
You might have something there, I will take a closer look at the test when I
can. So far I haven't been able to reproduce the test flakiness using your
branch on the EC2 I had created specifically to mimic the github runner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
