spmallette commented on code in PR #3212:
URL: https://github.com/apache/tinkerpop/pull/3212#discussion_r2362563031
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/util/TraversalHelperTest.java:
##########
@@ -600,4 +601,73 @@ public void shouldNotAffectNonRegisteredInterfaces() {
final List<Step<?,?>> steps = (List)
TraversalHelper.getStepsOfClass(Step.class, t);
assertEquals(0, steps.size());
}
+
+ @Test
+ public void hasOnlyShouldReturnTrueWhenAllStepsAreAssignable() {
+ final Traversal.Admin<?,?> t = __.V().out().has("name",
"marko").asAdmin();
+ final Set<Class> allowedClasses = Set.of(
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.GraphStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.VertexStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasStep.class
+ );
+
assertTrue(TraversalHelper.hasOnlyStepsOfAssignableClassesRecursively(allowedClasses,
t));
+ }
+
+ @Test
+ public void hasOnlyShouldReturnFalseWhenStepNotAssignable() {
+ final Traversal.Admin<?,?> t = __.V().out().count().asAdmin();
+ final Set<Class> allowedClasses = Set.of(
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.GraphStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.VertexStep.class
+ );
+
assertFalse(TraversalHelper.hasOnlyStepsOfAssignableClassesRecursively(allowedClasses,
t));
+ }
+
+ @Test
+ public void hasOnlyShouldWorkWithInterfaceClasses() {
+ final Traversal.Admin<?,?> t = __.V().out().asAdmin();
+ final Set<Class> allowedClasses = Set.of(
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.GraphStepContract.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.VertexStepContract.class
+ );
+
assertTrue(TraversalHelper.hasOnlyStepsOfAssignableClassesRecursively(allowedClasses,
t));
+ }
+
+ @Test
+ public void hasOnlyShouldWorkRecursivelyWithNestedTraversals() {
+ final Traversal.Admin<?,?> t = __.V().repeat(__.out().has("name",
"marko")).times(2).asAdmin();
+ final Set<Class> allowedClasses = Set.of(
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.GraphStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.branch.RepeatStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.branch.RepeatStep.RepeatEndStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.map.VertexStep.class,
+
org.apache.tinkerpop.gremlin.process.traversal.step.filter.HasStep.class
+ );
+
assertTrue(TraversalHelper.hasOnlyStepsOfAssignableClassesRecursively(allowedClasses,
t));
Review Comment:
nit: prefer hamcrest over assertTrue/False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
