Cole-Greer commented on code in PR #3213:
URL: https://github.com/apache/tinkerpop/pull/3213#discussion_r2369432190
##########
gremlin-python/src/main/python/setup.py:
##########
@@ -35,7 +35,7 @@
fd.write("'''")
fd.write(__doc__)
fd.write("'''\n")
- fd.write('version = %r\n' % os.getenv('VERSION',
'?').replace('-SNAPSHOT', '.dev-%d' % timestamp))
+ fd.write('version = %r\n' % os.getenv('VERSION',
'999.999.999.dev0').replace('-SNAPSHOT', '.dev-%d' % timestamp))
Review Comment:
Was this change necessary to get the python example running against the
local dev build? It might be worth looking at how the[ Maven Replacer plugin is
currently
used](https://github.com/apache/tinkerpop/blob/e39d795177c6d05deb1a463c2d7a2124d4fa56c7/gremlin-python/pom.xml#L70-L82)
to inject the gremlin version into
[useragent.py](https://github.com/apache/tinkerpop/blob/e39d795177c6d05deb1a463c2d7a2124d4fa56c7/gremlin-python/src/main/python/gremlin_python/driver/useragent.py#L21).
Perhaps that approach can be adapted to inject the correct version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
