Cole-Greer commented on code in PR #3217:
URL: https://github.com/apache/tinkerpop/pull/3217#discussion_r2392941043
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/SampleGlobalStep.java:
##########
@@ -154,7 +219,7 @@ private Optional<ProjectedTraverser<S, Number>>
createProjectedTraverser(final T
@Override
public Set<TraverserRequirement> getRequirements() {
- return this.getSelfAndChildRequirements(TraverserRequirement.BULK);
+ return this.getSelfAndChildRequirements(TraverserRequirement.BULK,
TraverserRequirement.NESTED_LOOP);
Review Comment:
Note: I don't think it's necessary to add a nested loop requirement to this
step, as in theory the only time this will be needed is if its inside a nested
repeat step, in which case `RepeatStep` itself will already be providing the
nested loop requirement. A similar argument would apply to any other steps
which may be given "loop awareness" such as `RangeGlobalStep`. Note how even
`LoopsStep` does not explicitly set a single loop or nested loop requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
