kmcginnes commented on code in PR #3238:
URL: https://github.com/apache/tinkerpop/pull/3238#discussion_r2437589190
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/package.json:
##########
@@ -2,14 +2,19 @@
"name": "gremlin",
"version": "3.8.0-alpha1",
"description": "JavaScript Gremlin Language Variant",
- "author": "Apache TinkerPop team",
+ "author": {
+ "name": "Apache TinkerPop team"
+ },
Review Comment:
I'm not sure what is typical. I wasn't aware the `author` field could
contain other values in an object, so I looked up [the
spec](https://docs.npmjs.com/cli/v7/configuring-npm/package-json#people-fields-author-contributors).
The only other field that looked useful here was `url`, unless there's an
Apache Tinkerpop email address.
Not including the url here is totally fine. I was just checking in case it
was overlooked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
