spmallette commented on code in PR #3244:
URL: https://github.com/apache/tinkerpop/pull/3244#discussion_r2441257456


##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -623,8 +623,45 @@ gremlin> g.V().choose(__.values("age")).
 ==>peter
 ----
 
+*Removal of choose().option(Traversal, v)*
+
+The `choose().option(Traversal, v)` is rarely used in comparison to the other 
overloads with constants, predicates and Pick
+tokens. It is also not the recommended approach for performance reasons. In 
addition, the current implementation leads to
+confusion as it only evaluates if the traversal is productive, rather than 
performing comparison on based on the traversal's
+output value. Fixing this behavior would require extensive changes, as such we 
are removing this functionality from
+`choose()` in 3.8.0, with plans to reintroduce a properly implemented version 
in the next major release.

Review Comment:
   I think a `union` example would be relevant here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to