andreachild commented on code in PR #3241:
URL: https://github.com/apache/tinkerpop/pull/3241#discussion_r2441460864
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/RangeGlobalStep.java:
##########
@@ -39,7 +45,10 @@ public final class RangeGlobalStep<S> extends FilterStep<S>
implements RangeGlob
private long low;
private long high;
- private AtomicLong counter = new AtomicLong(0l);
+ /**
+ * If this range step is used inside a loop there can be multiple
counters, otherwise there should only be one
+ */
+ private Map<String, AtomicLong> counters = new HashMap<>();
Review Comment:
In general yes nested repeats can be less performant than the unrolled
equivalent but that was the case even prior to this change. I believe that is
the reason for creating the RepeatUnrollStrategy which will optimize by
unrolling simple repeat traversals if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
