andreachild commented on code in PR #3252:
URL: https://github.com/apache/tinkerpop/pull/3252#discussion_r2471265680
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AbstractAddElementStepPlaceholder.java:
##########
@@ -128,20 +127,7 @@ protected E map(Traverser.Admin<S> traverser) {
@Override
public int hashCode() {
- int hash = super.hashCode();
- if (label != null) {
- hash ^= label.hashCode();
- }
- if (elementId != null) {
- hash ^= elementId.hashCode();
- }
- if (properties != null) {
- for (Map.Entry<Object, List<Object>> entry :
properties.entrySet()) {
- hash ^= Objects.hashCode(entry.getKey());
- hash ^= Objects.hashCode(entry.getValue());
- }
- }
- hash ^= withConfiguration.hashCode();
+ int hash = Objects.hash(super.hashCode(), label, elementId,
properties, withConfiguration);
return hash;
Review Comment:
Nit:
```suggestion
return Objects.hash(super.hashCode(), label, elementId, properties,
withConfiguration);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
