kenhuuu commented on code in PR #3267:
URL: https://github.com/apache/tinkerpop/pull/3267#discussion_r2488292134
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/DateDiffStep.java:
##########
@@ -95,7 +95,7 @@ protected Long map(final Traverser.Admin<S> traverser) {
}
// let's not throw exception and assume null date == 0
- return otherDate == null ? date.toEpochSecond() :
Duration.between(otherDate, date).getSeconds();
+ return otherDate == null ? date.toEpochSecond() :
Duration.between(otherDate, date).toMillis();
Review Comment:
`otherDate == null ? date.toEpochSecond()` should be millis too now, right?
If it is, add back a test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
