spmallette commented on PR #3287: URL: https://github.com/apache/tinkerpop/pull/3287#issuecomment-3702226125
Thanks for your patience on this one (I think others are still away for the holiday so we may yet need a bit more time to get all the feedback in). I'd never thought to add this kind of functionality, but it seems like it could be useful for folks. I added a few nits as comments. Here's a couple other items to consider: 1. Please add an entry to CHANGELOG.asciidoc to describe this change. 1. Some user documentation for this feature might be nice. I think it could go here: https://github.com/apache/tinkerpop/blob/3.8-dev/docs/src/reference/gremlin-applications.asciidoc#configuring - it could go in a new section perhaps? or maybe just needs a few words and examples in an existing section? 1. It's a small new feature but might yet be useful to call out in the Upgrade Documentation: https://github.com/apache/tinkerpop/blob/3.8-dev/docs/src/upgrade/release-3.8.1.asciidoc I'm happy to help with the documentation tasks if you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
