kenhuuu commented on code in PR #3289:
URL: https://github.com/apache/tinkerpop/pull/3289#discussion_r2670364480
##########
gremlint/src/formatQuery/__tests__/dotsAfterLineBreaks.test.ts:
##########
@@ -51,11 +50,10 @@ test('If dots are configured to be placed after line
breaks, make sure they are
).toBe(`g.V()
.hasLabel('person')
.group()
- .by(
- values('name', 'age').fold())
+ .by(values('name', 'age')
+ .fold())
.unfold()
- .filter(
- select(values)
- .count(local)
- .is(gt(1)))`);
+ .filter(select(values)
+ .count(local)
Review Comment:
I don't think this needs to be changed but to me this looks very odd. In
Java code, when you break a chain of methods for something like fluent APIs
into separate lines, there would usually be extra indentation to show which
part the next line is supposed to be connected to. Having the starting `.` line
up exactly with the step before it just looks a bit odd. Again, just pointing
this out in case anyone else feels the same but I probably wouldn't change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
