spmallette commented on code in PR #3303: URL: https://github.com/apache/tinkerpop/pull/3303#discussion_r2783893903
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/JavascriptTranslateVisitor.java: ########## @@ -38,6 +38,8 @@ * <li>Makes anonymous traversals explicit with double underscore</li> * <li>Makes enums explicit with their proper name</li> * </ul> + * <p/> + * Assumes use of https://www.npmjs.com/package/uuid library for UUID handling. Review Comment: we were already committed to using `uuid` though: https://github.com/apache/tinkerpop/blob/3.8.0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/JavascriptTranslateVisitor.java#L222 all i did was use the `parse` mechanism for a defined uuid. i suppose we could remove the translation wholly? but then a part of Gremlin doesn't work which now has a `uuid()` function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
