xiazcy commented on code in PR #3299:
URL: https://github.com/apache/tinkerpop/pull/3299#discussion_r2785163333
##########
gremlin-go/driver/driverRemoteConnection.go:
##########
@@ -70,44 +80,46 @@ func NewDriverRemoteConnection(
LogVerbosity: Info,
Logger: &defaultLogger{},
Language: language.English,
- AuthInfo: &AuthInfo{},
TlsConfig: &tls.Config{},
- KeepAliveInterval: keepAliveIntervalDefault,
- WriteDeadline: writeDeadlineDefault,
ConnectionTimeout: connectionTimeoutDefault,
EnableCompression: false,
EnableUserAgentOnConnect: true,
- ReadBufferSize: readBufferSizeDefault,
- WriteBufferSize: writeBufferSizeDefault,
- MaximumConcurrentConnections: runtime.NumCPU(),
+ MaximumConcurrentConnections: 0, // Use default (128)
Review Comment:
This is for the zero value convention for applying defaults, which in this
case is a constant applied in connection.go if the input value is 0, it's just
to use that instead of writing the constant in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
