xiazcy commented on code in PR #3315:
URL: https://github.com/apache/tinkerpop/pull/3315#discussion_r2963005082
##########
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs:
##########
@@ -44,22 +44,20 @@ public class DriverRemoteConnection : IRemoteConnection,
IDisposable
private readonly ILogger<DriverRemoteConnection> _logger;
/// <summary>
- /// Filter on these keys provided to OptionsStrategy and apply them to
the request. Note that
- /// "scriptEvaluationTimeout" was deprecated in 3.3.9 but still
supported in server implementations and will
- /// be removed in later versions.
+ /// Filter on these keys provided to OptionsStrategy and apply
them to the request.
/// </summary>
private readonly List<string> _allowedKeys = new()
{
- Tokens.ArgsEvalTimeout, "scriptEvaluationTimeout",
Tokens.ArgsBatchSize,
- Tokens.RequestId, Tokens.ArgsUserAgent,
Tokens.ArgMaterializeProperties
+ Tokens.ArgsEvalTimeout, Tokens.ArgsBatchSize,
+ Tokens.RequestId, Tokens.ArgsUserAgent,
+ Tokens.ArgMaterializeProperties, Tokens.ArgsBulkResults
};
- private readonly string? _sessionId;
- private string Processor => IsSessionBound ? Tokens.ProcessorSession :
Tokens.ProcessorTraversal;
-
/// <inheritdoc />
public bool IsSessionBound => _sessionId != null;
-
+
+ private readonly string? _sessionId;
Review Comment:
Was just a line change as part of the Tx(), removed given we'll redo tx
stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
