spmallette commented on PR #3336: URL: https://github.com/apache/tinkerpop/pull/3336#issuecomment-4117745446
> However, it seems like the GremlinTranslatorTest isn't really a one for one with the newly added gremlin-translator-test. Why is that the case? Those tests in java and javascript mostly developed out of unit testing in trying to get the translators to work. I didn't think a 1:1 was necessary or reasonable to think that we'd continue to keep them in sync over time. The heavy testing and what is expected to stay in sync comes from the feature tests. aside from `g.tx()` and a few terminals, i'm not sure there's much else to cover that isn't handled by the feature tests. i've pushed some more tests to help better cover that. > You should probably clarify what canonical casing actually is for enums since the examples there suggest PascalCase but we have enums like DT. We might need something there about using "Infinity" and "NaN" instead of language specific versions. pushed an improvement there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
