xiazcy opened a new pull request, #3359: URL: https://github.com/apache/tinkerpop/pull/3359
https://issues.apache.org/jira/browse/TINKERPOP-3232 Originally thought of using HashableDict, but ended up with deserializing into list instead due to potential hash collision and silent mutations of nested objects. Given gremlin-go also uses lists to back its custom set type, this wouldn't be an exclusion. Also this best preserves the inner data and type, which is usually what users operate on. However, I did keep a commit with the HashableDict.of() in case we favor that solution instead. Note there could be an improvement to this, where we use `frozenset` for `set` instead of `tuple` in the HashableDict implementation. (I will add CHANGELOG entry after the decision is made on the approach.) VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
