Cole-Greer commented on PR #3360: URL: https://github.com/apache/tinkerpop/pull/3360#issuecomment-4136616313
Hi @milesbxf, Thanks for submitting this PR. Before getting into the changes, I wanted to let you know that we are currently in code freeze in preparation for a set of releases (3.7.6, 3.8.1, and 4.0.0-beta.2) next week, and are not currently considering new submissions for these releases. Your changes here will be considered for the following release cycle. I did want to ask about which version you intend to target with your changes. If you're unfamiliar with our branching strategy, `3.7-dev` accumulates changes for the 3.7.x release line, `3.8-dev` for 3.8.x, and `master` is currently accumulating changes for `4.0.0`. If you want to target multiple release lines, we ask you target the oldest branch, and we will merge the changes up to later releases for you after your PR is merged. Gremlin-go looks very different under the hood in TinkerPop 4 (`master`) compared to 3.x.x, as TinkerPop 4 uses HTTP as a transport, while TinkerPop 3 uses WebSockets. Is your intention here to contribute instrumentation solely to gremlin-go 4, or did you want to add it to an existing 3.7.x/3.8.x release line which you are currently using? If you are looking for instrumentation in TinkerPop 3, I would ask that you open an additional PR targetting either `3.7-dev` or `3.8-dev` with a websockets implementation, in addition to this HTTP implementation for TinkerPop 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
