Cole-Greer commented on code in PR #3433:
URL: https://github.com/apache/tinkerpop/pull/3433#discussion_r3397856522
##########
gremlin-server/pom.xml:
##########
@@ -173,6 +173,16 @@ limitations under the License.
</archive>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-jar-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>test-jar</goal>
Review Comment:
That jar carries the PDT test fixtures
(org.apache.tinkerpop.gremlin.server.pdt.{Point,Person,Address}) that the GLV
integration tests reference (e.g. new
org.apache.tinkerpop.gremlin.server.pdt.Point(...) in Groovy). Without the
test-jar the image build fails at that COPY, which breaks the JS/Python/.NET/Go
integration suites.
I've put the execution back and added a comment explaining the Dockerfile
dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
