spmallette commented on code in PR #3471: URL: https://github.com/apache/tinkerpop/pull/3471#discussion_r3454358593
########## docs/src/upgrade/release-4.x.x.asciidoc: ########## @@ -151,6 +151,22 @@ Key behaviors consistent across all GLVs: See the <<gremlin-drivers-variants,Gremlin Drivers and Variants>> reference documentation for language-specific syntax and examples. +==== `Transaction.open()` Replaced by `begin()` + +The `open()` method has been removed from the `Transaction` API. Use `begin()` instead, which is now the single +transaction-start method for both embedded and remote contexts. Replace any `tx.open()` or `g.tx().open()` calls with +`begin()`. This is a compile-time break and is straightforward to find and fix. + +In addition, `begin()` is idempotent: calling it when a transaction is already open does not start a new transaction +and does not throw, returning a `TraversalSource` bound to the existing transaction. For embedded graphs this replaces +the previous behavior where opening an already-open transaction threw `transactionAlreadyOpen()`; that exception Review Comment: Do we need to say: > that exceptionfactory (`Transaction.Exceptions.transactionAlreadyOpen()`) has been removed, That detail points to something internal to TinkerPop. Doesn't really seem relevant to me how the exception raises - it's just relevant that the exception isn't thrown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
