GumpacG commented on code in PR #3469: URL: https://github.com/apache/tinkerpop/pull/3469#discussion_r3475509796
########## docs/src/reference/gremlin-variants.asciidoc: ########## @@ -3188,13 +3190,21 @@ can be passed to the `Client` or `DriverRemoteConnection` instance as keyword ar [width="100%",cols="3,10,^2",options="header"] |========================================================= |Key |Description |Default -|headers |Additional headers that will be added to each request message. |`None` -|max_workers |Maximum number of worker threads. |Number of CPUs * 5 -|request_serializer |The request serializer implementation.|`gremlin_python.driver.serializer.GraphBinarySerializersV4` +|max_workers |Maximum number of worker threads. |Same as `max_connections` (128) |response_serializer |The response serializer implementation.|`gremlin_python.driver.serializer.GraphBinarySerializersV4` -|interceptors |The request interceptors to run after request serialization.|`None` +|interceptors |The request interceptors to run before the request body is serialized.|`None` |auth |An authentication interceptor. Always appended to the end of the interceptor list so it runs last. |`None` -|pool_size |The number of connections used by the pool. |4 +|max_connections |The maximum number of connections used by the pool. `pool_size` is accepted as a deprecated alias. |128 +|connect_timeout |Timeout in seconds for establishing the connection (TCP connect plus TLS handshake). |5 +|read_timeout |Per-read idle timeout in seconds applied while streaming a response. Resets per chunk. |`None` +|write_timeout |Timeout in seconds for writing a request to the transport. |`None` +|ssl |An `ssl.SSLContext` used for TLS connections. `ssl_options` is accepted as a deprecated alias. |`None` +|idle_timeout |How long in seconds an idle connection remains in the pool before being closed. |180 Review Comment: As discussed offline, Java had the inconsistent behaviour and is now fixed. This will remain for Python. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
