GumpacG opened a new pull request, #3507:
URL: https://github.com/apache/tinkerpop/pull/3507
Fix flaky gremlin-python test: test_client_side_timeout_set_for_aiohttp
The test asserted `str(err) == ""` on the caught timeout, assuming a bare
`asyncio.TimeoutError` (empty message). But the driver arms two read-timeout
timers at the same value the driver's asyncio.timeout wrapper and aiohttp's
sock_read timer and whichever fires first is a race. When aiohttp's wins, the
error is a `SocketTimeoutError` ("Timeout on reading data from socket"), so the
message assertion fails intermittently (seen on python-3.11 and python-3.12
across runs).
Fix: drop the brittle message-equality assertion. The test still catches
`TimeoutError` (both variants subclass it), still fails if no timeout occurs,
and still verifies the client recovers afterward, it just no longer pins a
library-internal message string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
