Cole-Greer commented on code in PR #3483:
URL: https://github.com/apache/tinkerpop/pull/3483#discussion_r3545508652
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV4.java:
##########
@@ -432,8 +438,14 @@ public Edge deserialize(final JsonParser jsonParser, final
DeserializationContex
e.setId(deserializationContext.readValue(jsonParser,
Object.class));
} else if
(jsonParser.getCurrentName().equals(GraphSONTokens.LABEL)) {
jsonParser.nextToken();
+ final java.util.Set<String> labels = new
java.util.LinkedHashSet<>();
Review Comment:
Following the [existing IO
docs](https://github.com/apache/tinkerpop/blob/eab8d7fecb3b5d6dc78abafaacf9487384fcccd9/docs/src/dev/io/graphson.asciidoc?plain=1#L451-L453)
in master, the edge label is already encoded as a list in the wire format. I'd
like the serializers to operate on edge labels as lists and leave the
EdgeCardinality=1 enforcement to the structure API. I think that gives us the
most flexibility for future changes, even though there are currently no plans
to have multilabelled edges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
