kenhuuu commented on code in PR #3512:
URL: https://github.com/apache/tinkerpop/pull/3512#discussion_r3599285272
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/grammar/ArgumentVisitor.java:
##########
@@ -112,15 +112,6 @@ public Object parseLong(final
GremlinParser.IntegerArgumentContext ctx) {
}
}
- @Override
- public Object visitBooleanArgument(final
GremlinParser.BooleanArgumentContext ctx) {
Review Comment:
I'd probably lean toward keeping these as they are real things in the
grammar. Candidate for removal if we remove it from the `Gremlin.g4` file as
well
##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -1544,11 +1544,6 @@ ioOptionsStringConstant
: K_IOU
;
-booleanArgument
Review Comment:
I believe the intention is to keep the 4.x and 3.8.x grammar aligned. Given
that 3.8 has already been released, we shouldn't do this deletion until 5.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
