Cole-Greer commented on code in PR #3520:
URL: https://github.com/apache/tinkerpop/pull/3520#discussion_r3605760513


##########
gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py:
##########
@@ -75,12 +75,12 @@ def submit(self, gremlin_lang):
                                          
request_options=self.extract_request_options(gremlin_lang))
         return RemoteTraversal(result_set)
 
-    def submitAsync(self, message, parameters=None, request_options=None):
+    def submitAsync(self, gremlin_lang):

Review Comment:
   We should arguably just take TinkerPop 4 as the opportunity to delete this 
deprecated overload instead of continuing to adjust it. It's been deprecated 
for 5 years at this point. We can kick that into a new JIRA to followup with 
later if you think it needs more discussion, or to take a more holistic view of 
the python deprecation situation when we aren't in a release cycle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to