This is an automated email from the ASF dual-hosted git repository.
xiazcy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git
The following commit(s) were added to refs/heads/master by this push:
new 04b5189a50 CTR remove obsolete hasId() unrolling feature scenario
(TINKERPOP-3273)
04b5189a50 is described below
commit 04b5189a502f3f2c8f33ea97ce46098b8eb9fb64
Author: Yang Xia <[email protected]>
AuthorDate: Wed Jul 22 19:58:06 2026 -0700
CTR remove obsolete hasId() unrolling feature scenario (TINKERPOP-3273)
---
.../test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs | 2 --
gremlin-go/driver/cucumber/gremlin.go | 1 -
gremlin-js/gremlin-javascript/test/cucumber/gremlin.js | 1 -
gremlin-python/src/main/python/tests/feature/gremlin.py | 1 -
.../gremlin/language/translator/translations.json | 17 -----------------
.../gremlin/test/features/filter/HasId.feature | 15 ---------------
6 files changed, 37 deletions(-)
diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
index 886ce0ed96..32526a1bf2 100644
--- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
+++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/Gremlin.cs
@@ -550,7 +550,6 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
{"g_V_hasIdXeqXnullXX", new List<Func<GraphTraversalSource,
IDictionary<string, object>, ITraversal>> {(g,p) =>g.V().HasId(P.Eq(null))}},
{"g_V_hasIdX2_nullX", new List<Func<GraphTraversalSource,
IDictionary<string, object>, ITraversal>> {(g,p) =>g.V().HasId(p["vid2"],
null)}},
{"g_V_hasIdXmarkovar_vadasvarX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid1"], p["vid2"])}},
- {"g_V_hasIdXmarkovar_vadasvar_petervarX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid1"], p["vid2"])}},
{"g_V_hasIdX2AsString_nullX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid2"], null)}},
{"g_V_hasIdX1AsString_2AsString_nullX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid1"], p["vid2"], null)}},
{"g_V_hasIdXnull_2X", new List<Func<GraphTraversalSource,
IDictionary<string, object>, ITraversal>> {(g,p) =>g.V().HasId(null,
p["vid2"])}},
@@ -2905,7 +2904,6 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
{"g_V_hasIdXeqXnullXX", new List<Func<GraphTraversalSource,
IDictionary<string, object>, ITraversal>> {(g,p) =>g.V().HasId(P.Eq(null))}},
{"g_V_hasIdX2_nullX", new List<Func<GraphTraversalSource,
IDictionary<string, object>, ITraversal>> {(g,p) =>g.V().HasId(p["vid2"],
null)}},
{"g_V_hasIdXmarkovar_vadasvarX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid1"], p["vid2"])}},
- {"g_V_hasIdXmarkovar_vadasvar_petervarX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid1"], p["vid2"])}},
{"g_V_hasIdX2AsString_nullX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid2"], null)}},
{"g_V_hasIdX1AsString_2AsString_nullX", new
List<Func<GraphTraversalSource, IDictionary<string, object>, ITraversal>>
{(g,p) =>g.V().HasId(p["vid1"], p["vid2"], null)}},
{"g_V_hasIdXnull_2X", new List<Func<GraphTraversalSource,
IDictionary<string, object>, ITraversal>> {(g,p) =>g.V().HasId(null,
p["vid2"])}},
diff --git a/gremlin-go/driver/cucumber/gremlin.go
b/gremlin-go/driver/cucumber/gremlin.go
index 39a86734d8..064b1c6261 100644
--- a/gremlin-go/driver/cucumber/gremlin.go
+++ b/gremlin-go/driver/cucumber/gremlin.go
@@ -503,7 +503,6 @@ var translationMap = map[string][]func(g
*gremlingo.GraphTraversalSource, p map[
"g_V_hasIdXeqXnullXX": {func(g *gremlingo.GraphTraversalSource, p
map[string]interface{}) *gremlingo.GraphTraversal {return
g.V().HasId(gremlingo.P.Eq(nil))}},
"g_V_hasIdX2_nullX": {func(g *gremlingo.GraphTraversalSource, p
map[string]interface{}) *gremlingo.GraphTraversal {return
g.V().HasId(p["vid2"], nil)}},
"g_V_hasIdXmarkovar_vadasvarX": {func(g *gremlingo.GraphTraversalSource, p
map[string]interface{}) *gremlingo.GraphTraversal {return
g.V().HasId(p["vid1"], p["vid2"])}},
- "g_V_hasIdXmarkovar_vadasvar_petervarX": {func(g
*gremlingo.GraphTraversalSource, p map[string]interface{})
*gremlingo.GraphTraversal {return g.V().HasId(p["vid1"], p["vid2"])}},
"g_V_hasIdX2AsString_nullX": {func(g *gremlingo.GraphTraversalSource, p
map[string]interface{}) *gremlingo.GraphTraversal {return
g.V().HasId(p["vid2"], nil)}},
"g_V_hasIdX1AsString_2AsString_nullX": {func(g
*gremlingo.GraphTraversalSource, p map[string]interface{})
*gremlingo.GraphTraversal {return g.V().HasId(p["vid1"], p["vid2"], nil)}},
"g_V_hasIdXnull_2X": {func(g *gremlingo.GraphTraversalSource, p
map[string]interface{}) *gremlingo.GraphTraversal {return g.V().HasId(nil,
p["vid2"])}},
diff --git a/gremlin-js/gremlin-javascript/test/cucumber/gremlin.js
b/gremlin-js/gremlin-javascript/test/cucumber/gremlin.js
index 8bbf4ff005..f51d3ccfbe 100644
--- a/gremlin-js/gremlin-javascript/test/cucumber/gremlin.js
+++ b/gremlin-js/gremlin-javascript/test/cucumber/gremlin.js
@@ -534,7 +534,6 @@ const gremlins = {
g_V_hasIdXeqXnullXX: [function({g}) { return g.V().hasId(P.eq(null)) }],
g_V_hasIdX2_nullX: [function({g, vid2}) { return g.V().hasId(vid2, null)
}],
g_V_hasIdXmarkovar_vadasvarX: [function({g, vid2, vid1}) { return
g.V().hasId(vid1, vid2) }],
- g_V_hasIdXmarkovar_vadasvar_petervarX: [function({g, vid2, vid1}) { return
g.V().hasId(vid1, vid2) }],
g_V_hasIdX2AsString_nullX: [function({g, vid2}) { return g.V().hasId(vid2,
null) }],
g_V_hasIdX1AsString_2AsString_nullX: [function({g, vid2, vid1}) { return
g.V().hasId(vid1, vid2, null) }],
g_V_hasIdXnull_2X: [function({g, vid2}) { return g.V().hasId(null, vid2)
}],
diff --git a/gremlin-python/src/main/python/tests/feature/gremlin.py
b/gremlin-python/src/main/python/tests/feature/gremlin.py
index 16165e1e8a..54717fdbd4 100644
--- a/gremlin-python/src/main/python/tests/feature/gremlin.py
+++ b/gremlin-python/src/main/python/tests/feature/gremlin.py
@@ -508,7 +508,6 @@ world.gremlins = {
'g_V_hasIdXeqXnullXX': [(lambda g:g.V().has_id(P.eq(None)))],
'g_V_hasIdX2_nullX': [(lambda g, vid2=None:g.V().has_id(vid2, None))],
'g_V_hasIdXmarkovar_vadasvarX': [(lambda g,
vid2=None,vid1=None:g.V().has_id(vid1, vid2))],
- 'g_V_hasIdXmarkovar_vadasvar_petervarX': [(lambda g,
vid2=None,vid1=None:g.V().has_id(vid1, vid2))],
'g_V_hasIdX2AsString_nullX': [(lambda g, vid2=None:g.V().has_id(vid2,
None))],
'g_V_hasIdX1AsString_2AsString_nullX': [(lambda g,
vid2=None,vid1=None:g.V().has_id(vid1, vid2, None))],
'g_V_hasIdXnull_2X': [(lambda g, vid2=None:g.V().has_id(None, vid2))],
diff --git
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/language/translator/translations.json
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/language/translator/translations.json
index b74b97e5c6..0a84bf57b9 100644
---
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/language/translator/translations.json
+++
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/language/translator/translations.json
@@ -9279,23 +9279,6 @@
}
]
},
- {
- "scenario": "g_V_hasIdXmarkovar_vadasvar_petervarX",
- "traversals": [
- {
- "original": "g.V().hasId(vid1, vid2)",
- "language": "g.V().hasId(vid1, vid2)",
- "canonical": "g.V().hasId(vid1, vid2)",
- "anonymized": "g.V().hasId(vid1, vid2)",
- "dotnet": "g.V().HasId(vid1, vid2)",
- "go": "g.V().HasId(vid1, vid2)",
- "groovy": "g.V().hasId(vid1, vid2)",
- "java": "g.V().hasId(vid1, vid2)",
- "javascript": "g.V().hasId(vid1, vid2)",
- "python": "g.V().has_id(vid1, vid2)"
- }
- ]
- },
{
"scenario": "g_V_hasIdX2AsString_nullX",
"traversals": [
diff --git
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/HasId.feature
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/HasId.feature
index 39900fea15..862d02c8c4 100644
---
a/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/HasId.feature
+++
b/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/HasId.feature
@@ -107,21 +107,6 @@ Feature: Step - hasId()
| v[marko] |
| v[vadas] |
- Scenario: g_V_hasIdXmarkovar_vadasvar_petervarX
- Given the modern graph
- And using the parameter vid1 defined as "v[marko].id"
- And using the parameter vid2 defined as "l[v[vadas].id,v[peter].id]"
- And the traversal of
- """
- g.V().hasId(vid1, vid2)
- """
- When iterated to list
- Then the result should be unordered
- | result |
- | v[marko] |
- | v[vadas] |
- | v[peter] |
-
Scenario: g_V_hasIdX2AsString_nullX
Given the modern graph
And using the parameter vid2 defined as "v[vadas].sid"
