Cole-Greer commented on code in PR #3576:
URL: https://github.com/apache/tinkerpop/pull/3576#discussion_r3677195945


##########
bin/process-docs.sh:
##########
@@ -34,6 +34,13 @@ set -e
 cd "$(dirname "$0")/.."
 TP_HOME="$(pwd)"
 
+# The docs build renders every book to both HTML and Markdown in a single 
Maven JVM (AsciidoctorJ
+# runs in-process), so the heap must hold the parsed AST + JRuby runtime for 
~two dozen executions.
+# Raise the heap unless the caller already set one, to avoid OutOfMemoryError 
during rendering.
+if [[ "${MAVEN_OPTS:-}" != *-Xmx* ]]; then
+  export MAVEN_OPTS="${MAVEN_OPTS:-} -Xmx8g"

Review Comment:
   8GB seems like a crazy amount of memory for a docs build system, I wonder if 
that will get us in trouble with having scheduled SNAPSHOT docs deployments 
from GitHub actions runners. I don't think it's a concern for now, but we might 
need to find a way to slim this down in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to