Cole-Greer commented on code in PR #3583:
URL: https://github.com/apache/tinkerpop/pull/3583#discussion_r3680506813
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONStreamConstraintsTest.java:
##########
@@ -48,8 +48,8 @@ public void testMaxNumberLengthConfig() throws Exception {
serializeDeserializeAuto(mapper, serializedData);
});
assertTrue("Expected StreamConstraintsException for exceeding max
number length, found: "+exception.getMessage(),
-
exception.getMessage().contains("org.apache.tinkerpop.shaded.jackson.core.exc.StreamConstraintsException:
Number length")
- && exception.getMessage().contains("exceeds the maximum length
(2)"));
+
exception.getMessage().contains("org.apache.tinkerpop.shaded.jackson.core.exc.StreamConstraintsException:
Number value length")
+ && exception.getMessage().contains("exceeds the maximum
allowed (2, from `StreamReadConstraints.getMaxNumberLength()`)"));
Review Comment:
I think I'd rather continue asserting the full message even if it leaves us
prone to changing these tests again in the future. It's useful to know when
jackson is changing the messages on us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
