Cole-Greer commented on code in PR #3586: URL: https://github.com/apache/tinkerpop/pull/3586#discussion_r3885779207
########## THREAT_MODEL.md: ########## @@ -232,7 +232,7 @@ Knobs that change which security properties hold (Gremlin Server, `gremlin-serve `gremlin-server-secure.yaml`. The docs are explicit that TinkerPop offers no complete out-of-the-box protection against nefarious scripts. *(documented โ `gremlin-applications.asciidoc` "Protecting Script Execution", the two sample configs)* -- **Enabled serializers** โ wire set is GraphSON 3.0 + GraphBinary. Gryo is IO-format-only, not on the wire, +- **Enabled serializers** โ the default wire set is GraphSON 3.0 + GraphBinary. The typed GraphSON 1.0 serializer (`vnd.gremlin-v1.0+json`) is also shippable and screens its `@class` default typing against an allow-list of exact class names before loading the class (ยง8). Gryo is IO-format-only, not on the wire, Review Comment: I think we can probably drop any threat model changes from this PR, such updates are probably best handled separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
