paul-lartigau commented on code in PR #3715:
URL: https://github.com/apache/tinkerpop/pull/3715#discussion_r4335767110
##########
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/EventStrategyProcessTest.java:
##########
@@ -1051,6 +1052,39 @@ public void vertexPropertyChanged(final Vertex element,
final VertexProperty old
assertThat(triggered.get(), is(true));
}
+ @Test
+ @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
+ public void
shouldCaptureOldVertexPropertyWhenChangedWithDefaultCardinality() {
+ assumeTrue(graph.features().vertex().getCardinality("to-change") ==
VertexProperty.Cardinality.single);
Review Comment:
Thanks for the review. I added the test for default `set` cardinality
(`shouldCaptureOldVertexPropertyWhenChangedWithDefaultSetCardinality`),
configured
through `TinkerGraphProvider#getBaseConfiguration()` (and the same for
`TinkerTransactionGraphProvider`) following the existing pattern.
I also added two tests that Codecov flagged as uncovered:
- `set` with a value that is not yet present (no old property captured)
- default `list` cardinality (no old property captured; behavior unchanged
by the fix)
I confirmed that the single and set tests fail without the fix. Squashed
into a
single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
